Help, m42 won't start

[kaiser16]

Hey everyone, my 91 318is won't start. When I turn the ignition it clicks and I have power to anything else but the starter won't turn.
Things I have tried:
Checked the fuses and cleaned all the connections to the starter
Bypassed the relays by connecting pin 11 and 14 in the diagnostic terminal again same thing
Connected the constant 12v terminal on the starter to the signal wire with a screw driver still nothing
Replaced the starter assembly thinking I eliminated the relays being the source of the problem
Still nothing! what am I missing, any ideas??
The car works fine when push started so I don't think its the main relay
thanks

[Gerta]

You should have mod move this to the M42 engine section. Have you searched there for non-start threads? Lots of good info there.

oh, and welcome to R3V.

Gerta

[mr.vang]

Your starter is out. Smacking the starter is a temporary fix

[jdirty]

Your starter is out. Smacking the starter is a temporary fix

I second this. My old starter has some dents on it. But finally got around to replacing it.

If you push start it and the car's still running.. maybe your starter.
If it dies shortly after a push start.. then it could be your alternator.
Check your ground wires and CPS for gunk too.

[kaiser16]

the starter shouldn't be the problem, since I replaced it and before installing it I bench tested it
What is CPS short for?

[jdirty]

the starter shouldn't be the problem, since I replaced it and before installing it I bench tested it
What is CPS short for?

ohh okay. i didn't quite get the 'starter assembly' that you mentioned.
CPS - crankshaft position sensor.

[kaiser16]

Oh yes of course, i'll check it out but wouldn't the car have trouble running if the CPS is faulty, like i said the car ran fine when i push started it. Although the engine temperature sensor said that my car was overheating even though I only drove for 15min. I thought this would be a unrelated problem.